Fix clippy warnings and enforce -Dwarnings #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmunns
added
the
area: tools & build
jamesmunns
commented
Aug 10, 2023
|
8eebf74 failing is actually a nice check that -Dwarnings works :D |
|
@jamesmunns i wanna give this one a quick review if you don't mind, because i have some thoughts re: the justfile changes. |
hawkw
reviewed
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes existing clippy warnings and adds
-Dwarningsto the clippy invocationsof the justfile. I used the CLI args rather than RUSTFLAGS as there can be some issues
with overriding other rustflags used.
See rust-lang/cargo#8424 for more context re: rustflags issues